-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python313Packages.picologging: fix build; python313Packages.psycopg: 3.2.3 -> 3.2.4 python313Packages.shapely: build with cython3; litestar: build for all python version #374977
base: python-updates
Are you sure you want to change the base?
Conversation
1f61ce6
to
b07da29
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5117 |
72707ae
to
064a97b
Compare
nixpkgs-reviewd workflow finishedStatus and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/12865969944 |
7f32ec1
to
8fdb6df
Compare
c820fe9
to
f2b2a93
Compare
OK. But that nixpkgs-review is a bit strange. Some package failed on github actions can be built on my self computer. I will try to re-run it. |
0c83e95
to
89a7317
Compare
I think it should. Next time you're in this situation, you should open one merge request for each one of dependencies, andopen a draft PR for the package you're really interested in mentioning those as dependencies. It may seem a hassle for now, but believe me, you'll gain tons of time (and we will as well) in the long run:
So everybody go faster, contributors and reviewers. |
Many packages seemed to fail because selenium. Which is update on the python-update branch. Should we target this to 375144? |
89a7317
to
39b3cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the build log: some packages fail because of timing issues in tests (those should be disabled in nixpkgs). Also I'm pretty sure you have a numpy version mismatch issue somewhere, maybe due to the change of propagatedBuildInputs
to dependencies
in shapely.
Not sure. Usually what I do is rebase my PR onto the PR I need and mark mine as draft until the other is merged, but there may be a betters way. Anyway, you can try rebasing locally and see if you get lucky and the build works 😆 It's also possible that it is already broken on master (not everybody runs If the breakage is not directly linked to this MR, it's possible to merge it I think. |
@autra I have tested that It succeed in building on python-updates branch. |
39b3cb3
to
0fdffa5
Compare
@autra I'm not sure what you said for numpy. propagatedBuildInputs and dependencies are the same according to nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix Lines 365 to 370 in d9e47de
|
yes. It may not be this. There are a few errors about numpy and type mismatch. The other possibility would be because the package get a wrong python version because it is not defined in python-packages. But that is just my intuition, I'm not sure. |
@autra Could you list the package here. It's hard to find it. |
Yes, the packaging issue should be fixed in latest selenium release - SeleniumHQ/selenium#14823 |
17b228c
to
7af14b3
Compare
Sorry for so many changes. All these is need for litestar. I don't think it should be splited into more PRs.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.