Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python313Packages.picologging: fix build; python313Packages.psycopg: 3.2.3 -> 3.2.4 python313Packages.shapely: build with cython3; litestar: build for all python version #374977

Open
wants to merge 866 commits into
base: python-updates
Choose a base branch
from

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Jan 19, 2025

Sorry for so many changes. All these is need for litestar. I don't think it should be splited into more PRs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 changed the title python313Packages.picologging: fix build python313Packages.picologging: fix build; python313Packages.shapely: build with cython3; litestar: build for all python version Jan 20, 2025
@nix-owners nix-owners bot requested a review from natsukium January 20, 2025 10:07
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5117

@Bot-wxt1221 Bot-wxt1221 changed the title python313Packages.picologging: fix build; python313Packages.shapely: build with cython3; litestar: build for all python version python313Packages.picologging: fix build; python313Packages.psycopg: 3.2.3 -> 3.2.4 python313Packages.shapely: build with cython3; litestar: build for all python version Jan 20, 2025
@nix-owners nix-owners bot requested a review from mweinelt January 20, 2025 10:30
@Bot-wxt1221
Copy link
Member Author

@Bot-wxt1221 Bot-wxt1221 force-pushed the picologging branch 2 times, most recently from 7f32ec1 to 8fdb6df Compare January 20, 2025 10:37
@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft January 20, 2025 10:40
@Bot-wxt1221 Bot-wxt1221 force-pushed the picologging branch 2 times, most recently from c820fe9 to f2b2a93 Compare January 20, 2025 10:48
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review January 20, 2025 10:48
@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft January 21, 2025 04:35
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review January 21, 2025 04:38
@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Jan 21, 2025

OK. But that nixpkgs-review is a bit strange. Some package failed on github actions can be built on my self computer. I will try to re-run it.

@autra
Copy link
Contributor

autra commented Jan 21, 2025

Sorry for so many changes. All these is need for litestar. I don't think it should be splited into more PRs.

I think it should. Next time you're in this situation, you should open one merge request for each one of dependencies, andopen a draft PR for the package you're really interested in mentioning those as dependencies. It may seem a hassle for now, but believe me, you'll gain tons of time (and we will as well) in the long run:

  • one good change won't be blocked by those which are starting debates
  • nixpkgs-review will be faster
  • you'll get less reviewers by PR (only maintainers of said package), so less reviews, less comments, faster iteration and - - and it'll be easier to track for everybody

So everybody go faster, contributors and reviewers.

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Jan 21, 2025

Many packages seemed to fail because selenium. Which is update on the python-update branch. Should we target this to 375144?

@Bot-wxt1221 Bot-wxt1221 changed the base branch from master to python-updates January 21, 2025 10:03
Copy link
Contributor

@autra autra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the build log: some packages fail because of timing issues in tests (those should be disabled in nixpkgs). Also I'm pretty sure you have a numpy version mismatch issue somewhere, maybe due to the change of propagatedBuildInputs to dependencies in shapely.

@autra
Copy link
Contributor

autra commented Jan 21, 2025

Many packages seemed to fail because selenium. Which is update on the python-update branch. Should we target this to 375144?

Not sure. Usually what I do is rebase my PR onto the PR I need and mark mine as draft until the other is merged, but there may be a betters way. Anyway, you can try rebasing locally and see if you get lucky and the build works 😆

It's also possible that it is already broken on master (not everybody runs nixpkgs-review) and that the patch update won't fix it.

If the breakage is not directly linked to this MR, it's possible to merge it I think.

@Bot-wxt1221
Copy link
Member Author

@autra I have tested that It succeed in building on python-updates branch.

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Jan 21, 2025

@autra I'm not sure what you said for numpy. propagatedBuildInputs and dependencies are the same according to

propagatedBuildInputs = validatePythonMatches "propagatedBuildInputs" (
propagatedBuildInputs
++ dependencies
++ [
# we propagate python even for packages transformed with 'toPythonApplication'
# this pollutes the PATH but avoids rebuilds

@autra
Copy link
Contributor

autra commented Jan 21, 2025

@autra I'm not sure what you said for numpy. propagatedBuildInputs and dependencies are the same according to

propagatedBuildInputs = validatePythonMatches "propagatedBuildInputs" (
propagatedBuildInputs
++ dependencies
++ [
# we propagate python even for packages transformed with 'toPythonApplication'
# this pollutes the PATH but avoids rebuilds

yes. It may not be this. There are a few errors about numpy and type mismatch. The other possibility would be because the package get a wrong python version because it is not defined in python-packages. But that is just my intuition, I'm not sure.

@Bot-wxt1221
Copy link
Member Author

@autra Could you list the package here. It's hard to find it.

@Bot-wxt1221 Bot-wxt1221 requested a review from autra January 21, 2025 12:41
@imincik
Copy link
Contributor

imincik commented Jan 22, 2025

Many packages seemed to fail because selenium. Which is update on the python-update branch. Should we target this to 375144?

Yes, the packaging issue should be fixed in latest selenium release - SeleniumHQ/selenium#14823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants